Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for management canister logging #863

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Mar 20, 2024

Description

Previously, management canister queries had not been implemented, and attempts to use the new bitcoin and fetch_canister_logs features were not working correctly.

This adds support for queries to the management canister using effective canister ids, similar to how we have already done them for calls. Also adds e2e tests (locally) for reading logs

Screenshot 2024-03-20 at 2 20 12 PM

Note: logs are not enabled on all subnets on mainnet at present

Fixes SDK-1506

How Has This Been Tested?

new e2e tests

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner March 20, 2024 21:53
Copy link
Contributor

github-actions bot commented Mar 20, 2024

size-limit report 📦

Path Size
@dfinity/agent 102.23 KB (+0.41% 🔺)
@dfinity/candid 13.62 KB (+0.08% 🔺)
@dfinity/principal 5.04 KB (0%)
@dfinity/auth-client 92.84 KB (+0.11% 🔺)
@dfinity/assets 93.88 KB (+0.48% 🔺)
@dfinity/identity 90.1 KB (+0.15% 🔺)
@dfinity/identity-secp256k1 281.7 KB (+0.19% 🔺)

@krpeacock krpeacock merged commit c4c9ef9 into main Mar 22, 2024
15 checks passed
@krpeacock krpeacock deleted the kai/SDK-1506-management-verify-defect branch March 22, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants