fix: icx-proxy panic when decoding a response to http_request #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Candid 0.7.1 does not support decoding a Record into an IDLValue. We were using this in an unsupported way with Candid 0.6.x, but it doesn't work anymore. So, this commit specifies the exact type of the streaming http response token. Unfortunately, this means that we will no longer support arbitrary token types, but this is the best that we can do until Candid supports generic types: dfinity/candid#245
|
Does this fix #203? |
Yes, I think it will. We were running into errors like |
Daniel-Bloom-dfinity
added a commit
to Daniel-Bloom-dfinity/agent-rs
that referenced
this pull request
Mar 7, 2022
re: dfinity#221 dfinity#203 Turns out you can actually get around candid's limitation on `IDLValue`. It just takes some careful rejiggering. First, use `Reserved` to match anything. This seems like a valid use of `Reserved`, and should basically always be supported. Second, use `deserialize_ignored_any` to actually get all the content with our own visitor (really just a copy of `IDLValueVisitor`). This is a little bit of a hack, but it works.
ericswanson-dfinity
pushed a commit
that referenced
this pull request
Mar 7, 2022
* feat: Remake tokens generic re: #221 #203 Turns out you can actually get around candid's limitation on `IDLValue`. It just takes some careful rejiggering. First, use `Reserved` to match anything. This seems like a valid use of `Reserved`, and should basically always be supported. Second, use `deserialize_ignored_any` to actually get all the content with `IDLValueVisitor`. This is a little bit of a hack, but it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candid 0.7.1 does not support decoding a Record into an IDLValue. We were using this in an unsupported way with Candid 0.6.x, but it doesn't work anymore.
So, this commit specifies the exact type of the streaming http response token. Unfortunately, this means that we will no longer support arbitrary token types, but this is the best that we can do until Candid supports generic types: dfinity/candid#245