feat: Re-genericize tokens #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: dfinity#221 dfinity#203 Turns out you can actually get around candid's limitation on `IDLValue`. It just takes some careful rejiggering. First, use `Reserved` to match anything. This seems like a valid use of `Reserved`, and should basically always be supported. Second, use `deserialize_ignored_any` to actually get all the content with our own visitor (really just a copy of `IDLValueVisitor`). This is a little bit of a hack, but it works.
Daniel-Bloom-dfinity
requested review from
ericswanson-dfinity and
chenyan-dfinity
|
Should resolve this issue with streaming tokens. |
It should. I literally just copied the code of |
ericswanson-dfinity
approved these changes
Mar 7, 2022
chenyan-dfinity
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #221 #203
Turns out you can actually get around candid's limitation on
IDLValue. It just takes some careful rejiggering.First, use
Reservedto match anything. This seems like a valid use ofReserved, and should basically always be supported.Second, use
deserialize_ignored_anyto actually get all the content with our own visitor (really just a copy ofIDLValueVisitor). This is a little bit of a hack, but it works.