Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove global state from ic-cdk-macros #430

Merged
merged 2 commits into from Oct 2, 2023
Merged

Conversation

adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity commented Oct 2, 2023

Stateful macro crates can cause IDE errors when the IDE keeps a single instance of the macro crate loaded and runs it multiple times. This PR removes the last remaining global state from the macros.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review October 2, 2023 19:06
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner October 2, 2023 19:06
@lwshang lwshang enabled auto-merge (squash) October 2, 2023 19:20
@lwshang lwshang merged commit 847d689 into main Oct 2, 2023
16 checks passed
@lwshang lwshang deleted the spofford/no-global-state branch October 2, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants