Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(release-ci): bump cargo-dist 0.1.0 #48

Merged
merged 6 commits into from
Aug 16, 2023
Merged

refactor(release-ci): bump cargo-dist 0.1.0 #48

merged 6 commits into from
Aug 16, 2023

Conversation

smallstepman
Copy link
Contributor

@smallstepman smallstepman commented Aug 16, 2023

Updates release workflow to use cargo-dist 0.1.0: https://github.com/axodotdev/cargo-dist/releases/tag/v0.1.0
Example run of updated CI: https://github.com/smallstepman/dfx-extensions/actions/runs/5879509170
Example release after CI updates: https://github.com/smallstepman/dfx-extensions/releases/tag/sns-v23132123.231.123

Most notable changes:

  • cargo-dist compiles the package using the version of rust specified in rust-toolchain.toml
  • cargo-dist packages tarball into tar.gz (previously it was tar.xz which we had to repackage in CI)
  • cargo-dist calculates sha256 for the archive and uploads it as {archive_filename_with_file_extension}.sha256
  • cargo-dist changed the default naming convention for the tarball archive (from {package}-v{version}-{platform}.{ext} to {package}-{platform}.{ext}, read more here https://github.com/axodotdev/cargo-dist/issues/184)
  • fixed a bug that caused a package to get published in crates.io even when publish = false was specified in Cargo.toml

Additionally:

  • we're no longer using dtolnay/rust-toolchain@stable; rust toolchain comes preinstalled on GitHub Runners
  • cargo-binstall manual installation has been replaced with minimal GHA (see https://github.com/cargo-bins/cargo-binstall/pull/1269)
  • a few lints here and there

@smallstepman smallstepman requested review from a team as code owners August 16, 2023 13:46
@smallstepman smallstepman merged commit 6cfbc97 into dfinity:main Aug 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants