fix(extension): update tarball filename format #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the tarball no longer contains the version
ericswanson-dfinity
approved these changes
Aug 23, 2023
ericswanson-dfinity
approved these changes
Aug 28, 2023
smallstepman
force-pushed
the
mnl/update-extension-tarball-filename
branch
from
76bd27f
to
e46e2cc
Compare
|
@ericswanson-dfinity I forgot about auto-merge... do you think this was correct move e46e2cc ? Another option would be to build extensions using older ubuntu (20.04 instead of 22.04) |
|
@smallstepman Please change this back to ubuntu 20.04, and build extensions with that too. |
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfinity/dfx-extensions#48 changed how the filename of tarball and the name of the dir directly inside it; they no longer contain the version of the extension (meaning, we're going from
{package}-v{version}-{platform}.{ext}to{package}-{platform}.{ext})Awaits merging of dfinity/dfx-extensions#51 and dfinity/dfx-extensions#50
How Has This Been Tested?
covered by CI
Checklist:
I have edited the CHANGELOG accordingly.I have made corresponding changes to the documentation.