Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log-fetcher): binary fields that end with \n are not parsed correctly #213

Merged
merged 3 commits into from
Feb 27, 2024
Merged

fix(log-fetcher): binary fields that end with \n are not parsed correctly #213

merged 3 commits into from
Feb 27, 2024

Conversation

NikolaMilosa
Copy link
Contributor

No description provided.

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner February 27, 2024 13:31
sasa-tomic
sasa-tomic approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@NikolaMilosa NikolaMilosa added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 2d96e38 Feb 27, 2024
3 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-large-field-patch branch February 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

@pietrodimarco-dfinity pietrodimarco-dfinity pietrodimarco-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NikolaMilosa @sasa-tomic @pietrodimarco-dfinity