feat: ckBTC get_withdrawal_account and retrieve_btc #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
reviewed
Feb 14, 2023
lmuntaner
approved these changes
Feb 15, 2023
1 task
peterpeterparker
added a commit
to dfinity/nns-dapp
that referenced
this pull request
Feb 20, 2023
# Motivation This PR introduces the JS Api and Services layers to perform a conversion of ckBTC to BTC. # Note These services and API are provided without UI changes in this PR. # PRs - [x] dfinity/ic-js#292 # Changes - implements APIs for `get_withdrawal_account` and `retrieve_btc` - implement service logic that converts ckBTC to BTC - create an interface `IcrcTransferTokensUserParams` for our internal call to transfer tokens function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement and propose the two functions required to convert ckBTC to BTC.
Changes
get_withdrawal_accountandretrieve_btc