Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "Regtest" BTC network #713

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Add support for "Regtest" BTC network #713

merged 5 commits into from
Sep 6, 2024

Conversation

lmuntaner
Copy link
Contributor

Motivation

We want to use Regtest for local development in Oisy, but at the moment, this network is not supported in the BitcoinNetwork.

Changes

  • Add "regtest" as supported BitcoinNetwork and change the mapper to support the new value.

Tests

No new functionality.

Todos

  • Add entry to changelog (if necessary).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.99 KB (+0.13% 🔺)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.48 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.92 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 2.92 KB (0%)

@lmuntaner lmuntaner marked this pull request as ready for review September 6, 2024 12:59
@lmuntaner lmuntaner requested review from a team as code owners September 6, 2024 12:59
@lmuntaner
Copy link
Contributor Author

@dskloetd @peterpeterparker please review

peterpeterparker
peterpeterparker reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In few JS docs it's mentionned "(mainnet or testnet)" or "Tesnet or mainnet", should those comment be enhanced as well maybe?

@lmuntaner
Copy link
Contributor Author

lmuntaner commented Sep 6, 2024 •
edited
Loading

In few JS docs it's mentionned "(mainnet or testnet)" or "Tesnet or mainnet", should those comment be enhanced as well maybe?

Which docs?

IGNORE, I found it.

peterpeterparker
peterpeterparker approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@lmuntaner lmuntaner merged commit a5c26b3 into main Sep 6, 2024
11 checks passed
@lmuntaner lmuntaner deleted the lm-add-regtest branch September 6, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

@dskloetd dskloetd Awaiting requested review from dskloetd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmuntaner @peterpeterparker