chore(IDX): update slack notification #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
approved these changes
Jun 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
marko-k0
reviewed
Jun 5, 2024
| done | ||
| echo "channels=${CHANNELS}" >> $GITHUB_OUTPUT | ||
| TEAM=${{ steps.get-reviewers.outputs.result }} | ||
| CHANNEL=$(jq -r ".$TEAM" .github/workflows/team-channels.json) |
There was a problem hiding this comment.
We should handle the case where the team doesn't have a channel assigned yet. The following step would fail in that case I assume.
There was a problem hiding this comment.
Don't we want it to fail? So we know the team can't be notified?
gitlab-dfinity
pushed a commit
that referenced
this pull request
Jun 5, 2024
GitHub Sync PR#181 / chore(IDX): update slack notification [GitHub PR 181](#181) (branch: update-slack-notification) See merge request dfinity-lab/public/ic!19649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the action "ready for review" triggers before "review requested" so the payload doesn't always have the complete teams. This fix changes the trigger and will both trigger if a PR is directly opened as a non-draft and if additional reviewers are added later.