Array primitives #62
Merged
Array primitives #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulyoung here is something for you to play with. |
paulyoung
reviewed
Nov 7, 2018
| @@ -34,6 +34,16 @@ class revrange(x : Nat, y : Nat) { | |||
|
|
|||
| func printInt (x : Int) { ((prim "printInt") : Int -> ()) x }; | |||
| func print (x : Text) { ((prim "print") : Text -> ()) x }; | |||
|
|
|||
| /* This would be nicer as a objects, but lets do them as functions | |||
| until the compiler has a concept of “static objects” */ | |||
There was a problem hiding this comment.
I've been wondering about this 😃
There was a problem hiding this comment.
Some context: I've run into naming collisions quite a bit, and while I can fix that myself right now I imagine at some point people will want to depend on ActorScript code that they didn't write and there's no way to qualify names that conflict.
paulyoung
reviewed
Nov 7, 2018
|
I think this is working as expected. Am I correct in saying that a simple way to think of these 2 functions is:
|
|
Precisely! |
paulyoung
approved these changes
Nov 7, 2018
rossberg
approved these changes
Nov 8, 2018
src/prelude.ml
Outdated
| | [len; g] -> | ||
| let len_nat = Int.to_int (as_nat len) in | ||
| let (_, g') = Value.as_func g in | ||
| let rec go prefix k i = |
There was a problem hiding this comment.
Nit: some indentation seems to be off here
(I should auto-configure vim to have the right settings also for Ocaml)
dfinity-bot
added a commit
that referenced
this pull request
Dec 2, 2021
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@07cad526...9d250a8d](dfinity/ic-hs@07cad52...9d250a8) * [`9d250a8d`](dfinity/ic-hs@9d250a8) Simplify ([dfinity/ic-hs#62](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/ic-hs/issues/62))
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2021
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@07cad526...9d250a8d](dfinity/ic-hs@07cad52...9d250a8) * [`9d250a8d`](dfinity/ic-hs@9d250a8) Simplify ([dfinity/ic-hs#62](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/ic-hs/issues/62))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #57.