Potential work-around for Rollup cyclic dependency bug #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
added a commit
that referenced
this pull request
Apr 19, 2023
# Motivation When cleaning up the commit comparison tool I managed to delete the line where the local code is checked out. # Changes - Check out the commit being tested before running the local docker build. # Tests Running on a range of commits shows the repo being checked out: ``` $ ./scripts/nns-dapp/frontend-reproducibility-report Previous HEAD position was 027bd72 E2E: Stake an SNS neuron (#2316) HEAD is now at c01f191 Better command line url test (#2324) Previous HEAD position was c01f191 Better command line url test (#2324) HEAD is now at 38e3a55 fix: broken gap by tid (#2337) Previous HEAD position was 38e3a55 fix: broken gap by tid (#2337) HEAD is now at 388abdd Log pre-upgrade cycle count (#2335) Previous HEAD position was 388abdd Log pre-upgrade cycle count (#2335) HEAD is now at 2de7376 Style improvement for release candidate (#2334) Previous HEAD position was 2de7376 Style improvement for release candidate (#2334) HEAD is now at 51e4e1f Potential work-around for Rollup cyclic dependency bug (#2332) ``` Co-authored-by: Max Murphy-Skvorzov <max@winning.black>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug in Rollup that non-deterministically fails to detect cyclic
dependencies. rollup/plugins#1425
As a result
lru-cacheis sometimes wrapped in arequireLruCachefunction and sometimes it is not.This makes our build non-deterministic.
lru-cacehis not itself part of a circular dependency butsemver/classes/range.js, which depends onlru-cache, is.By depending on
lru-cachedirectly from our app, we change the order in which modules are analyzed by Rollup, hopefully avoiding the buggy behavior.It probably doesn't matter where we put this import, so I put it as close to the root of the app as I could find.
Changes
Add
import "lru-cache"in frontend/src/routes/+layout.tsTests
Inspected generated
vendorchunk to see that it does not havehasRequiredLruCache.dfx deploy nns-dapplocally and did some manual testing.