feat: add open flag to dfx deploy command #3618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippofinke
requested review from
chenyan-dfinity and
a team
as code owners
|
Dear @filippofinke, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
|
|
||
| if open_in_browser { | ||
| if let Err(e) = webbrowser::open(url.as_str()) { | ||
| info!(log, "Failed to open browser: {}", e); |
There was a problem hiding this comment.
Suggested change
| info!(log, "Failed to open browser: {}", e); | |
| error!(log, "Failed to open browser: {}", e); |
|
|
||
| if open_in_browser { | ||
| if let Err(e) = webbrowser::open(url.as_str()) { | ||
| info!(log, "Failed to open browser: {}", e); |
There was a problem hiding this comment.
Suggested change
| info!(log, "Failed to open browser: {}", e); | |
| error!(log, "Failed to open browser: {}", e); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new feature to the dfx deploy command where users can specify the --open flag to automatically open the URL of the deployed canisters in the default browser of the machine. This enhancement aims to improve user experience by providing a convenient way to access the deployed canisters immediately after deployment.
How Has This Been Tested?
To test this feature:
Checklist: