Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual walls #13

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Fix virtual walls #13

merged 2 commits into from
Jan 22, 2019

Conversation

niniemann
Copy link
Contributor

The previous configuration of the local costmap didn't work for me -- obstacles seen in the laser scans were not added, or were overridden by the virtual_walls_map layer. Reordering the layers and loading the virtual walls before the obstacles fixes this for me.

Also, I added a with_virtual_walls parameter to start_maps.launch and start_planner.launch.

@mintar
Copy link
Member

mintar commented Jan 22, 2019

Thanks!

Just a note for posterity: The virtual_walls_map layer seems to overwrite the obstacle layer when the free space in the virtual walls map is gray (= unknown). When the free space is white, like in mir_gazebo/maps/maze_virtual_walls.png, this doesn't happen.

Putting the virtual_walls_map layer below the obstacle layer (which is done in this PR) makes it work with gray values, too.

@mintar mintar merged commit 94cd831 into DFKI-NI:kinetic Jan 22, 2019
kdhansen pushed a commit to AAU-RoboticsAutomationGroup/mir_robot that referenced this pull request Dec 6, 2023
    * using NavFn planner + DWB local planner
    * added custom behavior tree for MiR
    * added robot footprint
    * adapted a few parameters
    * visualization updates in rviz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants