Move import of mpi4py to inside MPIPool initialization #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is that rare. Another example is often times if you're on the login node of a cluster, anything touching MPI will error out, so you can't test emcee unless you get a compute node. This PR fixes the issue for me in the couple of places I've run into it, it'd be great to have it merged. |
|
Thanks! Sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a downstream user with a broken MPI installation, which crashes on importing mpi4py. She also can't use emcee in serial mode, because the mpi_pool module tries importing mpi4py.MPI.
This change fixes that (certainly rare) issue by moving the mpi4py import to inside the MPIPool initialization.