Build testing #45
Merged
Build testing #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left over changes from 80b13e5
|
Includes, so |
awvwgk
reviewed
May 8, 2022
CMakeLists.txt
Outdated
| @@ -33,7 +33,7 @@ endif() | |||
| include(GNUInstallDirs) | |||
|
|
|||
| add_subdirectory(lib) | |||
| if(NOT BUILD_EXPORTED_TARGETS_ONLY) | |||
| if(NOT BUILD_EXPORTED_TARGETS_ONLY AND BUILD_TESTING) | |||
There was a problem hiding this comment.
This only works if you previously used include(CTest), further we should deprecate BUILD_EXPORTED_TARGETS_ONLY in favor of BUILD_TESTING or keep the old option and document it properly.
There was a problem hiding this comment.
Empirically, 9f812ae seemed to work correctly with cmake 3.18.4 as BUILD_TESTING was not defined.
There was a problem hiding this comment.
When reviewing fortran-lang/stdlib#629 not including CTest did lead to problems, which were related to caching and restarting builds.
awvwgk
requested changes
May 8, 2022
awvwgk
approved these changes
May 8, 2022
This was referenced May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Closes #42
Closes #41