Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.regtest.yml fixes #10

Merged
merged 3 commits into from
Feb 10, 2018
Merged

Conversation

vardars
Copy link
Contributor

@vardars vardars commented Feb 9, 2018

I couldn't use environment variables passed from docker-compose because vars didn't include BTC prefixes. Now I can use them with containers. I thought there was a usage change to support multiple coins, but docker-compose file became out-of-date.

@NicolasDorier
Copy link
Member

Good catch thanks!

@NicolasDorier NicolasDorier merged commit f29c535 into dgarage:master Feb 10, 2018
@NicolasDorier
Copy link
Member

I willl likely simplify this docker-compose later. By sharing the bitcoin datadir as a volume on the two containers, we can remove rpc related config by passing by cookiefile auth.

@vardars
Copy link
Contributor Author

vardars commented Feb 11, 2018

Thank you too my friend, it is really good to share these projects with community. If I can find time, I want to help with these changes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants