Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from using ssh to https for submodules #58

Merged

Conversation

jmitrevs
Copy link

Description

I think using https instead of ssh allows the test machines to more easily check out the submodules. Otherwise, it fails because there is no ssh key associated with them in github. Look at fastmachinelearning#982 vs fastmachinelearning#956

Type of change

  • Other (Specify)
    Submodule checkout method

Tests

This should enable pytests to work in our system. Compare fastmachinelearning#982 vs fastmachinelearning#956

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@dgburnette dgburnette merged commit 2539477 into dgburnette:catapult_backend Mar 18, 2024
@jmitrevs jmitrevs deleted the submodule_test branch March 29, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants