Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Room Info' needs implementation #25

Closed
dgets opened this issue Dec 9, 2014 · 11 comments
Closed

'Room Info' needs implementation #25

dgets opened this issue Dec 9, 2014 · 11 comments
Assignees

Comments

@dgets
Copy link
Owner

dgets commented Dec 9, 2014

Users need to be able to hit 'i' at primary menu prompt and potentially the message read prompt, as well, in order to pull up the information such as the room/sub-board's long name, creator/moderator, and blurb about the room (this might end up in an arbitrary directory), etc. A la vdoc style, of course.

@dgets
Copy link
Owner Author

dgets commented Jan 27, 2015

Handling this via /sbbs/user/ directory writes. See also http://wiki.synchro.net/dir:data?s[]=user.

@dgets
Copy link
Owner Author

dgets commented Jan 27, 2015

Actually, now that I look at this, it appears that it's a duplicate issue. See this issue, instead: Figure out a solution for custom user & sub info (#28). Cosing this for now.

@dgets dgets closed this as completed Jan 27, 2015
@dgets dgets reopened this Jan 31, 2015
@dgets
Copy link
Owner Author

dgets commented Jan 31, 2015

I'm going to continue this as a separate issue, as it doesn't really belong in 'dperuser.js'.

The header that this block of info should have is simple:

Sub Name> Forum Info

Forum moderator is <username>.  Total messages: xxx
Forum info last updated <whenever> by <username>

@dgets
Copy link
Owner Author

dgets commented Jan 31, 2015

Not that I've also just realized that non-hacked implementation of this will also require implementation of a separate sysop/aide mode in order to properly edit it. We might just hack around that for beta, as this is not really an essential feature at this point.

dgets added a commit that referenced this issue Jan 31, 2015
@dgets
Copy link
Owner Author

dgets commented Mar 10, 2015

Started hacking on this today; using @ntwitch's code in dperuser.js as a template to avoid gross formatting differences.

@dgets
Copy link
Owner Author

dgets commented Mar 22, 2015

If nothing else at this point, rewriting dperroom.js's appropriate routines in order to return the new record value as it was done in dperuser.js should work just fine.

Another idea would be to spawn a routine to build new records for each new room, as it is found at the beginning of any users' message read; kind of a maintenance done on the record base at every user's entry to the room. This would probably be best, as it would automatically update information which may have been changed by another user, in the same temporal frame of reference.

So yeah, I think that probably checking for the record at the entry to every room and writing a null one to the JSON file, if it doesn't exist, is the best tactic here. That'll work well with new rooms, as they're added to the base, as well. Unless there are any reasons that I don't know of to go with the initial idea. I don't think it'll work as well for this case, though.

dgets added a commit that referenced this issue Apr 13, 2015
dgets added a commit that referenced this issue Apr 13, 2015
@dgets
Copy link
Owner Author

dgets commented Apr 13, 2015

It appears that snagRoomInfoBlob() was originally hatched utilizing an idea about passing the roomFile and roomReq (evidently the name of the room's info to request or room code), while the requirements of that method have changed. It will be necessary to go back and rework this, along with the default record returns that it is using, in order to properly parse what is in the file, and eventually to return the contents properly.

@dgets
Copy link
Owner Author

dgets commented Apr 13, 2015

It should also be mentioned that the room info, though it can now, without loud error, allegedly be saved, it is not appearing in the info file yet.

@dgets
Copy link
Owner Author

dgets commented May 12, 2015

A little more debugging turns up a bit more on this:

Unable to snagRoomInfoBlob()
The scroll is blank!


[û] Change this?? Yes
Enter new room info here:
This is the lobby; important system announcements, etc, go here.
Just got: This is the lobby; important system announcements, etc, go here.
At index: 0

Just got:
At index: 1
<A>bort <C>ontinue <P>rint <S>ave <X>press -> Save...
mTxt: This is the lobby; important system announcements, etc, go here.,
length: 2
Being returned
Trying to load room info file: NaN (in snagRoomInfoBlob)
Unable to open conf file: [object File]
Error in stripNRead(): Unable to open [object File]
File: NaN
changeRoomInfo() exception: Exception in stripNRead()
message: Unable to open [object File]   num: 1

Lobby>
Forum Moderator is null.  Total messages: 4
Forum info last updated:  by null

Unable to snagRoomInfoBlob()
The scroll is blank!



Lobby>   

@dgets
Copy link
Owner Author

dgets commented May 20, 2015

See also issue #134.

@dgets
Copy link
Owner Author

dgets commented May 20, 2015

This may be a little bit buggy, but is finally now implemented. Closing this issue, as any minor bugs that pop up can be their own separate issues at this point.

@dgets dgets closed this as completed May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant