Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_local fix #575

Merged
merged 8 commits into from Apr 13, 2021
Merged

load_local fix #575

merged 8 commits into from Apr 13, 2021

Conversation

ahwagner
Copy link
Member

closes #572.

Live on staging. Ready to deploy after review.

@coveralls
Copy link

coveralls commented Apr 13, 2021 •
edited

Pull Request Test Coverage Report for Build 743040132

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 37.915%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/utils/snapshot_helpers.rb 0 1 0.0%
app/jobs/post_grouper.rb 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
app/jobs/post_grouper.rb 1 0%
lib/genome/groupers/gene_grouper.rb 1 91.3%
Totals Coverage Status
Change from base Build 743025799: -0.03%
Covered Lines: 2419
Relevant Lines: 6380
💛 - Coveralls

susannasiebert
susannasiebert approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Looks good to me. I tested it locally and it worked without problems.

acoffman
acoffman approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@acoffman acoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ahwagner ahwagner merged commit bf213b2 into master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoffman acoffman acoffman approved these changes

@susannasiebert susannasiebert susannasiebert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

database load_local not working
4 participants
@ahwagner @coveralls @acoffman @susannasiebert