should_set_tablename() doesn't handle declared_attr. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seth-p
force-pushed
the
should_set_tablename_declared_attr
branch
7 times, most recently
from
18ab0fe
to
03b2f7c
Compare
| @@ -93,6 +87,17 @@ def get_mapper_class(model, field): | |||
| return mapper_class(getattr(model, field)) | |||
|
|
|||
|
|
|||
| def _concrete_value(obj, cls, check_classmethod=False, check_callable=False): | |||
There was a problem hiding this comment.
Let's name this get_concrete_value and add a docstring.
|
Overall, I think the logic looks good. Just a few nits and this should be good to merge. |
seth-p
force-pushed
the
should_set_tablename_declared_attr
branch
from
03b2f7c
to
20ba678
Compare
seth-p
force-pushed
the
should_set_tablename_declared_attr
branch
from
20ba678
to
6921aaa
Compare
|
Looks good! Thanks! |
dgilland
added a commit
that referenced
this pull request
Apr 25, 2015
should_set_tablename() doesn't handle declared_attr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
test_should_set_tablename_declared_attr()to demonstrate thatshould_set_tablename()doesn't handle@declared_attrcolumns and relationships.I don't see how to fix this so long as
should_set_tablename()is called fromModelMeta.__new__()before the class is constructed.