Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml and ruff #221

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Conversation

DeviousStoat
Copy link
Contributor

fixes #219

One thing to note, with pyproject the importlib.metadata doesn't have the Author key so I had to change to use Author-email for the copyright in the docs.
So your name looks like Derrick Gilland <dgilland@gmail.com> instead of just Derrick Gilland in the copyright in the documentation page.
Seems to be a known issue. I can change it if you want but it didn't sound too bad.

@coveralls
Copy link

coveralls commented Feb 13, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 0c4346a on DeviousStoat:pyproject
into 40f21a1 on dgilland:develop.

Copy link
Owner

@dgilland dgilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Just had a few nits.

One thing to note, with pyproject the importlib.metadata doesn't have the Author key so I had to change to use Author-email for the copyright in the docs.

That's fine.

tasks.py Outdated Show resolved Hide resolved
tasks.py Outdated Show resolved Hide resolved
tasks.py Outdated Show resolved Hide resolved
tests/test_functions.py Outdated Show resolved Hide resolved
@dgilland
Copy link
Owner

Really appreciate the work here!

@DeviousStoat
Copy link
Contributor Author

Applied all the requested changes

@dgilland dgilland merged commit ef48d55 into dgilland:develop Feb 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ruff
3 participants