fix: parenthesis now appear in printed quote objects #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one ended up exposing a few other bugs related to handling of parenthesis.
Before they weren't actually part of the syntax tree. They just existed through the structure of the tree itself - implicit to the interpreter but non-obvious when printed. Anything that looked like it printed reasonably before was just little tricks I had shoved in to make it look reasonable along the way.
Now parenthesis have their own symbol so this should be much more rigorously handled in the future.
I also spent a little time cleaning up
substitute(), which does some "automatic" parentheses insertion when operator precedence might affect behaviors, similar to R.