Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: AttributeError: 'TridonicDALIUSBNoResponse' object has no attribute 'value' #66

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

Hadatko
Copy link
Contributor

@Hadatko Hadatko commented Feb 3, 2024

It looks like the dali device is not able to return physical minimum value some amount of time when it is turned on. It looks like variable is not used anyway so i bypassed it for now

…ibute 'value'

It looks like the dali device is not able to return physical minimum value some amount of time when it is turned on. It looks like variable is not used anyway so i bypassed it for now

Signed-off-by: Dusan Cervenka <cervenka.dusan@gmail.com>
@Hadatko
Copy link
Contributor Author

Hadatko commented Feb 3, 2024

related to #63

Copy link
Owner

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be less broad (Exception) and narrow down the exception ?

(this does require changes in python-dali)

dali2mqtt/lamp.py Outdated Show resolved Hide resolved
@Hadatko
Copy link
Contributor Author

Hadatko commented Feb 3, 2024

That is something beetween you guys :D I just need solve issues somehow

@Hadatko
Copy link
Contributor Author

Hadatko commented Feb 3, 2024

But you got error and you are parsing value from it. So i think you should handle that somehow.

dali2mqtt/lamp.py Outdated Show resolved Hide resolved
@dgomes dgomes merged commit 82f5e2e into dgomes:master Feb 3, 2024
3 checks passed
@dgomes
Copy link
Owner

dgomes commented Feb 3, 2024

Thanks @Hadatko

@Hadatko Hadatko deleted the bugfix/physical_value branch February 3, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants