forked from apache/zookeeper
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ZOOKEEPER-1514. FastLeaderElection - leader ignores the round informa…
…tion when joining a quorum (flavio via henryr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1368737 13f79535-47bb-0310-9956-ffa450edef68
- Loading branch information
Showing
5 changed files
with
266 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154 changes: 154 additions & 0 deletions
154
src/java/test/org/apache/zookeeper/test/FLEBackwardElectionRoundTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| /* Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.zookeeper.test; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.net.InetSocketAddress; | ||
| import java.nio.ByteBuffer; | ||
| import java.util.HashMap; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.apache.zookeeper.PortAssignment; | ||
| import org.apache.zookeeper.ZKTestCase; | ||
| import org.apache.zookeeper.server.quorum.QuorumCnxManager; | ||
| import org.apache.zookeeper.server.quorum.QuorumPeer; | ||
| import org.apache.zookeeper.server.quorum.Vote; | ||
| import org.apache.zookeeper.server.quorum.QuorumPeer.QuorumServer; | ||
| import org.apache.zookeeper.server.quorum.QuorumPeer.ServerState; | ||
| import org.junit.After; | ||
| import org.junit.Assert; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| import org.apache.zookeeper.test.FLETestUtils.LEThread; | ||
|
|
||
| public class FLEBackwardElectionRoundTest extends ZKTestCase { | ||
| protected static final Logger LOG = LoggerFactory.getLogger(FLELostMessageTest.class); | ||
|
|
||
| int count; | ||
| HashMap<Long,QuorumServer> peers; | ||
| File tmpdir[]; | ||
| int port[]; | ||
|
|
||
| QuorumCnxManager cnxManagers[]; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| count = 3; | ||
|
|
||
| peers = new HashMap<Long,QuorumServer>(count); | ||
| tmpdir = new File[count]; | ||
| port = new int[count]; | ||
| cnxManagers = new QuorumCnxManager[count - 1]; | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() throws Exception { | ||
| for(int i = 0; i < (count - 1); i++){ | ||
| if(cnxManagers[i] != null){ | ||
| cnxManagers[i].halt(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * This test is checking the following case. A server S is | ||
| * currently LOOKING and it receives notifications from | ||
| * a quorum indicating they are following S. The election | ||
| * round E of S is higher than the election round E' in the | ||
| * notification messages, so S becomes the leader and sets | ||
| * its epoch back to E'. In the meanwhile, one or more | ||
| * followers turn to LOOKING and elect S in election round E. | ||
| * Having leader and followers with different election rounds | ||
| * might prevent other servers from electing a leader because | ||
| * they can't get a consistent set of notifications from a | ||
| * quorum. | ||
| * | ||
| * {@link https://issues.apache.org/jira/browse/ZOOKEEPER-1514} | ||
| * | ||
| * | ||
| * @throws Exception | ||
| */ | ||
|
|
||
| @Test | ||
| public void testBackwardElectionRound() throws Exception { | ||
| LOG.info("TestLE: " + getTestName()+ ", " + count); | ||
| for(int i = 0; i < count; i++) { | ||
| int clientport = PortAssignment.unique(); | ||
| peers.put(Long.valueOf(i), | ||
| new QuorumServer(i, | ||
| new InetSocketAddress(clientport), | ||
| new InetSocketAddress(PortAssignment.unique()))); | ||
| tmpdir[i] = ClientBase.createTmpDir(); | ||
| port[i] = clientport; | ||
| } | ||
|
|
||
| /* | ||
| * Start server 0 | ||
| */ | ||
|
|
||
| QuorumPeer peer = new QuorumPeer(peers, tmpdir[0], tmpdir[0], port[0], 3, 0, 1000, 2, 2); | ||
| peer.startLeaderElection(); | ||
| FLETestUtils.LEThread thread = new FLETestUtils.LEThread(peer, 0); | ||
| thread.start(); | ||
|
|
||
|
|
||
| /* | ||
| * Start mock server 1 | ||
| */ | ||
| QuorumPeer mockPeer = new QuorumPeer(peers, tmpdir[1], tmpdir[1], port[1], 3, 1, 1000, 2, 2); | ||
| cnxManagers[0] = new QuorumCnxManager(mockPeer); | ||
| QuorumCnxManager.Listener listener = cnxManagers[0].listener; | ||
| listener.start(); | ||
|
|
||
| cnxManagers[0].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1)); | ||
|
|
||
| /* | ||
| * Start mock server 2 | ||
| */ | ||
| mockPeer = new QuorumPeer(peers, tmpdir[2], tmpdir[2], port[2], 3, 2, 1000, 2, 2); | ||
| cnxManagers[1] = new QuorumCnxManager(mockPeer); | ||
| listener = cnxManagers[1].listener; | ||
| listener.start(); | ||
|
|
||
| cnxManagers[1].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1)); | ||
|
|
||
| /* | ||
| * Run another instance of leader election. | ||
| */ | ||
| thread.join(5000); | ||
| thread = new FLETestUtils.LEThread(peer, 0); | ||
| thread.start(); | ||
|
|
||
| /* | ||
| * Send the same messages, this time should not make 0 the leader. | ||
| */ | ||
| cnxManagers[0].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1)); | ||
| cnxManagers[1].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1)); | ||
|
|
||
|
|
||
| thread.join(5000); | ||
|
|
||
| if (!thread.isAlive()) { | ||
| Assert.fail("Should not have joined"); | ||
| } | ||
|
|
||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| /* Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.zookeeper.test; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
|
|
||
| import org.apache.zookeeper.server.quorum.QuorumPeer; | ||
| import org.apache.zookeeper.server.quorum.Vote; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.junit.Assert; | ||
|
|
||
| import org.apache.zookeeper.server.quorum.QuorumPeer.ServerState; | ||
|
|
||
| public class FLETestUtils { | ||
| protected static final Logger LOG = LoggerFactory.getLogger(FLETestUtils.class); | ||
|
|
||
|
|
||
| /* | ||
| * Thread to run an instance of leader election for | ||
| * a given quorum peer. | ||
| */ | ||
| static class LEThread extends Thread { | ||
| private int i; | ||
| private QuorumPeer peer; | ||
|
|
||
| LEThread(QuorumPeer peer, int i) { | ||
| this.i = i; | ||
| this.peer = peer; | ||
| LOG.info("Constructor: " + getName()); | ||
|
|
||
| } | ||
|
|
||
| public void run(){ | ||
| try{ | ||
| Vote v = null; | ||
| peer.setPeerState(ServerState.LOOKING); | ||
| LOG.info("Going to call leader election: " + i); | ||
| v = peer.getElectionAlg().lookForLeader(); | ||
|
|
||
| if (v == null){ | ||
| Assert.fail("Thread " + i + " got a null vote"); | ||
| } | ||
|
|
||
| /* | ||
| * A real zookeeper would take care of setting the current vote. Here | ||
| * we do it manually. | ||
| */ | ||
| peer.setCurrentVote(v); | ||
|
|
||
| LOG.info("Finished election: " + i + ", " + v.getId()); | ||
|
|
||
| Assert.assertTrue("State is not leading.", peer.getPeerState() == ServerState.LEADING); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } | ||
| LOG.info("Joining"); | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| * Creates a leader election notification message. | ||
| */ | ||
|
|
||
| static ByteBuffer createMsg(int state, long leader, long zxid, long epoch){ | ||
| byte requestBytes[] = new byte[28]; | ||
| ByteBuffer requestBuffer = ByteBuffer.wrap(requestBytes); | ||
|
|
||
| /* | ||
| * Building notification packet to send | ||
| */ | ||
|
|
||
| requestBuffer.clear(); | ||
| requestBuffer.putInt(state); | ||
| requestBuffer.putLong(leader); | ||
| requestBuffer.putLong(zxid); | ||
| requestBuffer.putLong(epoch); | ||
|
|
||
| return requestBuffer; | ||
| } | ||
|
|
||
| } |