Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sandeepk blog feed #14

Merged
merged 1 commit into from
May 10, 2021
Merged

add sandeepk blog feed #14

merged 1 commit into from
May 10, 2021

Conversation

Skchoudhary
Copy link

No description provided.

@jasonbraganza
Copy link
Member

@Skchoudhary, fix whatever conflict here?

@Skchoudhary
Copy link
Author

@jasonbraganza done

@jasonbraganza
Copy link
Member

@SaptakS this one too, please

@sayanchowdhury
Copy link
Member

Seems like this still has conflicts.

@jasonbraganza
Copy link
Member

it looks good to me. @Skchoudhary can you recheck anyway please?

@Skchoudhary
Copy link
Author

It looks good to me also. But the only issue I see is that my blog feed entry is not the last one. Should I move my blog feed entry to last, or it's okay? @sayanchowdhury @jasonbraganza

@SaptakS
Copy link
Member

SaptakS commented May 10, 2021

No need to move to the last. Can you just rebase on master and then push back? Rebasing and merging shows conflict.

@Skchoudhary
Copy link
Author

@SaptakS please have a look now

Copy link
Member

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SaptakS SaptakS merged commit cc8d802 into dgplug:master May 10, 2021
@jasonbraganza
Copy link
Member

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants