-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the NextSequence feature. #346
Conversation
Reviewed 2 of 2 files at r1. db.go, line 1104 at r1 (raw file):
Add comment that it doesn't work in managed DB. db.go, line 1111 at r1 (raw file):
Throw error if bandwidth == 0 Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions. db.go, line 1108 at r1 (raw file):
(Disclaimer: I don’t fully understand the use of this) So, the Comments from Reviewable |
Review status: 1 of 5 files reviewed at latest revision, 3 unresolved discussions. db.go, line 1104 at r1 (raw file): Previously, janardhan1993 (Janardhan Reddy) wrote…
DONE. Good point. I've added a panic for mdb. And added a comment. db.go, line 1108 at r1 (raw file): Previously, deepakjois (Deepak Jois) wrote…
Yes. It's convenience v/s flexibility, I chose convenience. One can always iterate and pick values from some number N, if they want to start from N. db.go, line 1111 at r1 (raw file): Previously, janardhan1993 (Janardhan Reddy) wrote…
Done. Comments from Reviewable |
Cool! Review status: 1 of 5 files reviewed at latest revision, 3 unresolved discussions. Comments from Reviewable |
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)