Cast results of len to uint32 to fix compilation in i386 arch. #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOARCH=386 go build ./ passes with this change and fails without it due to integer overflow. Fixes #953
martinmr
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
golangcibot
reviewed
Aug 2, 2019
martinmr
commented
Aug 2, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @golangcibot, and @manishrjain)
table/builder.go, line 176 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
line is 101 characters (from
lll)
Done.
golangcibot
reviewed
Aug 2, 2019
manishrjain
approved these changes
Aug 5, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @golangcibot, and @martinmr)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 9, 2019
GOARCH=386 go build ./ passes with this change and fails without it due to integer overflow. Fixes #953
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOARCH=386 go build ./ passes with this change and fails without it due
to integer overflow.
Fixes #953
This change is