v23.0.0 Update & Clean PR #3: Update test projects and examples #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mangalaman93
requested review from
MichelDiz,
all-seeing-code,
joshua-goldstein and
sanjayk-github-dev
|
@mangalaman93 I recommend merging only this PR and closing the other two. That way the tests should pass, and that will complete Phase 1. I can provide instructions for building and publishing the package to NuGet if necessary. |
MichelDiz
reviewed
Jul 13, 2023
source/Dgraph.tests.e2e/Tests/Approved/SchemaTest.AlterSchemAsExpected.approved.txt
Show resolved
Hide resolved
sachyco
force-pushed
the
pr-3
branch
4 times, most recently
from
5dcf8a7
to
c726805
Compare
|
@sachyco please rebase the PR on latest master |
@mangalaman93 Done |
mangalaman93
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored unit tests, e2e tests, and examples to use the updated client & transaction interfaces. Otherwise there are no functional changes or additional tests added.
Some key file changes are in the
source/Dgraph.tests.e2e/Tests/Approved/folder. Please review these to confirm that the updated schemas are correct. The new schemas were updated by running their respective tests and copying the received output. It is possible that the client or the unit tests have bugs that I do not have the dgraph expertise to diagnose.