v23.0.0 Update & Clean PR #2: Dgraph Client Refactor #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mangalaman93
requested changes
Jul 11, 2023
mangalaman93
requested review from
all-seeing-code,
MichelDiz,
joshua-goldstein and
sanjayk-github-dev
MichelDiz
reviewed
Jul 12, 2023
|
I was able to merge the first PR, please do a rebase and we will review this PR. |
Rebase complete @mangalaman93 |
mangalaman93
requested changes
Jul 13, 2023
There was a problem hiding this comment.
a few more comments, this looks good to me. @all-seeing-code @MichelDiz please review & approve once my comments are addressed.
mangalaman93
requested changes
Jul 18, 2023
mangalaman93
approved these changes
Jul 18, 2023
|
Tests fail right now. Is that expected? |
|
@all-seeing-code yeah, next PR will fix it |
all-seeing-code
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changed files contain simple style, formatting, and naming cleanup.
Functional changes are mainly related to aligning this client to the dgo client and are concentrated in these classes/interfaces:
DgraphCloudChannelCreatemethod implements the dgoDialCloudlogic.DgraphClientIDgraphClientDgraphClientclass directly.TransactionDomethod similar to the dgo implementation.ITransactionTransactionclass directly.IQueryTransactionclass is hidden behind this interface when creating it withclient.NewReadOnlyTransactionRequestBuilderMutationBuilderREADME.md is also heavily rewritten to match the dgo readme as closely as possible.
Note: The tests will fail until PR #34 is merged.