-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/supporting types graphql #185
Conversation
…io/dgraph into feature/supporting-types-graphql
… schema, remove redundant code
|
||
if val, err := strconv.ParseFloat(input, 32); err != nil { | ||
return 0, err | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
Getting closer. Reviewed 6 of 6 files at r6. query/query.go, line 268 [r7] (raw file):
Form proper sentences. query/query_test.go, line 563 [r5] (raw file):
|
Review status: 4 of 9 files reviewed at latest revision, 24 unresolved discussions, some commit checks broke. types/definitions.go, line 42 [r6] (raw file):
|
Reviewed 11 of 12 files at r8, 1 of 1 files at r9. cmd/dgraph/main.go, line 65 [r9] (raw file):
hmm.. wouldn't the loader need this? If so, this should lie in the package where it's used. gql/schema.go, line 65 [r9] (raw file):
This is a very simplistic function. This doesn't even need to be a function. Also, the trace adds little value here, because most predicates won't have an type def. query/query.go, line 490 [r9] (raw file):
The context is being passed just for SchemaType, which is a map lookup. I don't think this adds much value. Remove this. Comments from Reviewable |
Review status: all files reviewed at latest revision, 16 unresolved discussions, some commit checks failed. cmd/dgraph/main.go, line 65 [r9] (raw file):
|
Reviewed 2 of 12 files at r8, 3 of 3 files at r11. gql/schema.go, line 60 [r11] (raw file):
what happens if p isn't inside the schema map? Comments from Reviewable |
Review status: all files reviewed at latest revision, 15 unresolved discussions, some commit checks failed. gql/schema.go, line 60 [r11] (raw file):
|
Review status: all files reviewed at latest revision, 15 unresolved discussions, some commit checks failed. gql/schema.go, line 60 [r11] (raw file):
|
Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed. Comments from Reviewable |
Got LGTM. Closing as merged to master. |
@CodeLingoBot capture Check Type Before Casting |
@CodeLingoBot capture Avoid Ending Flag Arg Name In UpperCase |
@CodeLingoBot capture Don't Sprint values that are already strings |
@CodeLingoBot capture comments end in a full stop |
New PR for #172
Need to implement/discuss:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)