Fix error when exporting a predicate to the schema. #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic only adds the '<' and '>' characters around the predicate list if it has something other than numbers and letters. However, this logic is faulty since a predicate consisting of only numbers needs to have the surrounding brackets to be properly parsed. This change removes that logic and adds the surrounding brackets to all predicates for simplicity and correctness.
martinmr
changed the title
gitlw
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)
manishrjain
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic only adds the '<' and '>' characters around the
predicate list if it has something other than numbers and letters.
However, this logic is faulty since a predicate consisting of only
numbers needs to have the surrounding brackets to be properly parsed.
This change removes that logic and adds the surrounding brackets to all
predicates for simplicity and correctness.
Fixes #3699
This change is