Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v1.2: Update badger 06/09/2020 #5615

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

dgraph-bot
Copy link
Contributor

@dgraph-bot dgraph-bot commented Jun 9, 2020

This PR updates badger. The important changes are

KeepL0InMemory -> Set to false (badger default)
DetectConflicts -> Set to false

This change is Reviewable

Docs Preview: Dgraph Preview

@dgraph-bot dgraph-bot requested review from manishrjain and a team as code owners June 9, 2020 23:11
@jarifibrahim jarifibrahim self-assigned this Jun 10, 2020
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update contains conflict detection changes in badger. We need to disable the flag.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)

@jarifibrahim jarifibrahim merged commit 51364e8 into release/v1.2 Jun 15, 2020
@jarifibrahim jarifibrahim deleted the dgraph-bot/release/v1.2-update-06/09/2020 branch June 15, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants