test: Enterprise License tests

[antblood]

Adding files for Enterprise license unit testing and Integration testing.
Fixes DGRAPH-1348
There are three tests in it:

1. Applying expired license, this will get applied but it should not be enabled and user information should be extracted
2. Applying invalid license, this won't get applied
3. Applying empty license, this also won't get applied

---

This change is 

Docs Preview:

[pawanrawal]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @antblood, @manishrjain, and @vvbalaji-dgraph)

---

dgraph/cmd/zero/enterpriseExperiedKey.key, line 13 at r1 (raw file):

	DQTievpyQF47HzuifvqUyxDSEsYiSGhhap1e/tvf1VaZoFUuTYQQpiV7+9K3UrL0
	SnJ5TRWS7cEKBLyZszrakGpqVakvEUlWO4wG0Fp4kUa4YXw8t58oqHRn9aAtoqJd
	UOLnq2semUttaySR4DHhjneO3/RoVm79/aaqMi/QNJzc9Tt9nY0AgcYlA3bVXmAZ

ExpiredKey and not Experied

---

dgraph/cmd/zero/enterpriseUnit_test.go, line 22 at r1 (raw file):

	}{
		{
			"Using expired entrerprised license key should return an error",

enterprise

---

dgraph/cmd/zero/enterpriseUnit_test.go, line 24 at r1 (raw file):

			"Using expired entrerprised license key should return an error",
			expiredKey,
			true,

Is this ever false? If not then do we even need it?

---

dgraph/cmd/zero/enterpriseUnit_test.go, line 41 at r1 (raw file):

	for _, tt := range tests {
		t.Logf("Running: %s\n", tt.name)
		err := server.applyLicenseFileReturnError(expiredKey)

Shouldn't you be taking this value from tt.licenseKeyPath?

---

dgraph/cmd/zero/license_ee.go, line 151 at r1 (raw file):

}

func (s *Server) applyLicenseFileReturnError(path string) error {

Change the name to applyLicenseFile. No need to add ReturnError because that is clear from the function definition itself.

---

dgraph/cmd/zero/license_ee.go, line 154 at r1 (raw file):

	content, err := ioutil.ReadFile(path)
	if err != nil {
		glog.Infof("Unable to apply license at %v due to error %v", path, err)

Do we have a test for this as well i.e. for a non-existent file? Why are we printing the error if we are already returning it to the user as well?

[harshil-goel]

Reviewable status: 2 of 3 files reviewed, 13 unresolved discussions (waiting on @antblood, @manishrjain, and @vvbalaji-dgraph)

---

dgraph/cmd/zero/enterpriseExperiedKey.key, line 2 at r2 (raw file):

-----BEGIN PGP MESSAGE-----
	owEBwgI9/ZANAwAKAXomeeH3SyppAax7YgxsaWNlbnNlLmpzb25etF5+ewogICJ1

Indentation problem

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 20 at r2 (raw file):

)

var expiredKey = []byte(`-----BEGIN PGP MESSAGE-----

Read it from the file itself.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 47 at r2 (raw file):

	var (
		dgraph = flag.String("d", "127.0.0.1:9080", "Dgraph Alpha address")

check testutil.SockAddr, we already have a dgraph alpha address as a input, use that instead.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 70 at r2 (raw file):

		log.Fatal(err)
	}
	fmt.Printf("Response: %s\n", resp.Json)

Remove this

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 72 at r2 (raw file):

	fmt.Printf("Response: %s\n", resp.Json)

	enterpriseLicenseURL := "http://localhost:6080/enterpriseLicense"

What is at 6080?

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 100 at r2 (raw file):

		require.NoError(t, err)
		correctError := strings.Contains(string(responseBody), tt.expectedOutput)
		// errors := unmarshaledBody.(map[string]interface{})["errors"].([]interface{})[0].(map[string]interface{})["message"]

Remove this

---

dgraph/cmd/zero/enterpriseInvalidKey.key, line 2 at r2 (raw file):

-----BEGIN PGP MESSAGE-----
	owEBwgI9/ZANAwAKAXomeeH3SyppAax7YgxsaWNlbnNlLmpzb25etF5+ewogICJ1

Indentation error

[antblood]

Reviewable status: 2 of 3 files reviewed, 13 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @pawanrawal, and @vvbalaji-dgraph)

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 47 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

check testutil.SockAddr, we already have a dgraph alpha address as a input, use that instead.

Done.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 70 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

Remove this

Done.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 72 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

What is at 6080?

Done.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 100 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

Remove this

Done.

---

dgraph/cmd/zero/enterpriseInvalidKey.key, line 2 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

Indentation error

Done.

---

dgraph/cmd/zero/enterpriseUnit_test.go, line 22 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

enterprise

Done.

---

dgraph/cmd/zero/enterpriseUnit_test.go, line 24 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Is this ever false? If not then do we even need it?

Done.

---

dgraph/cmd/zero/enterpriseUnit_test.go, line 41 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Shouldn't you be taking this value from tt.licenseKeyPath?

Done.

---

dgraph/cmd/zero/license_ee.go, line 151 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Change the name to applyLicenseFile. No need to add ReturnError because that is clear from the function definition itself.

Done.

---

dgraph/cmd/zero/license_ee.go, line 154 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Do we have a test for this as well i.e. for a non-existent file? Why are we printing the error if we are already returning it to the user as well?

Done.

[antblood]

Reviewable status: 2 of 3 files reviewed, 13 unresolved discussions (waiting on @harshil-goel, @manishrjain, @pawanrawal, and @vvbalaji-dgraph)

---

dgraph/cmd/zero/enterpriseExperiedKey.key, line 13 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

ExpiredKey and not Experied

Done.

---

dgraph/cmd/zero/enterpriseExperiedKey.key, line 2 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

Indentation problem

Done.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 20 at r2 (raw file):

Previously, harshil-goel (Harshil Goel) wrote…

Read it from the file itself.

Done.

[martinmr]

In the future, use "git rm" and "git mv" when removing and moving files so that they are tracked appropriately. Otherwise the changelist looks off.

One small comment but otherwise it

Reviewed 1 of 3 files at r3.
Reviewable status: all files reviewed, 15 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @pawanrawal, and @vvbalaji-dgraph)

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 1 at r3 (raw file):

package zero

license_test.go should be enough.

---

dgraph/cmd/zero/enterpriseIntegration_test.go, line 67 at r3 (raw file):

		}
		require.NoError(t, err)
		require.Equal(t, true, correctError)

I think there's a require.Contains function you can use here to directly compare the two strings.

[martinmr]

Marking as approved.

Reviewable status: all files reviewed, 15 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @pawanrawal, and @vvbalaji-dgraph)

[pawanrawal]

Reviewable status: 0 of 2 files reviewed, 19 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)

---

systest/license/license_test.go, line 71 at r4 (raw file):

		name           string
		licenseKey     []byte
		expectError    bool

not needed if its false always

---

systest/license/license_test.go, line 74 at r4 (raw file):

		code           string
		user           string
		licenseEnabled interface{}

not needed if its nil always

---

systest/license/license_test.go, line 110 at r4 (raw file):

		responseBody, err := ioutil.ReadAll(response.Body)
		require.NoError(t, err)
		json.Unmarshal(responseBody, &enterpriseResponse)

We should also compare the error message returned to the user. Also, check errors that are returned from json.Unmarshal

---

systest/license/license_test.go, line 124 at r4 (raw file):

			responseBody, err := ioutil.ReadAll(response.Body)
			require.NoError(t, err)
			json.Unmarshal(responseBody, &stateResponse)

check error here

[antblood]

Reviewable status: 0 of 2 files reviewed, 19 unresolved discussions (waiting on @harshil-goel, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)

---

systest/license/license_test.go, line 71 at r4 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

not needed if its false always

Done.

---

systest/license/license_test.go, line 74 at r4 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

not needed if its nil always

Done.

---

systest/license/license_test.go, line 110 at r4 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

We should also compare the error message returned to the user. Also, check errors that are returned from json.Unmarshal

Done.

---

systest/license/license_test.go, line 124 at r4 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

check error here

Done.

[ashish-goswami]

Reviewable status: 0 of 2 files reviewed, 21 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)

---

systest/license/license_test.go, line 1 at r5 (raw file):

package main

Dgraph license is missing here.

---

systest/license/license_test.go, line 77 at r5 (raw file):

func TestEnterpriseLicense(t *testing.T) {
	t.Log("Running TestEnterpriseLicense\n")

I think this can be removed as something like this already printed while running tests.

[ashish-goswami]

Reviewed 1 of 3 files at r4, 1 of 1 files at r5.
Reviewable status: all files reviewed, 21 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)

[martinmr]

Reviewable status: all files reviewed, 21 unresolved discussions (waiting on @antblood, @harshil-goel, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)

[antblood]

Reviewable status: all files reviewed, 21 unresolved discussions (waiting on @ashish-goswami, @harshil-goel, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)

---

systest/license/license_test.go, line 1 at r5 (raw file):

Previously, ashish-goswami (Ashish Goswami) wrote…

Dgraph license is missing here.

Done.

---

systest/license/license_test.go, line 77 at r5 (raw file):

Previously, ashish-goswami (Ashish Goswami) wrote…

I think this can be removed as something like this already printed while running tests.

Done.