fix(worker): Flush the stream writer on error (DGRAPH-2499) #6609
Conversation
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
worker/snapshot.go
Outdated
| return | ||
| } | ||
| // Flush the writer if it has not been flushed so that we can unblock the writes. | ||
| if err := writer.Flush(); err != nil { |
There was a problem hiding this comment.
We could add a cancel API on stream writer to fix this in a more elegant way.
There was a problem hiding this comment.
@ajeetdsouza is working on resolving this.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)
worker/snapshot.go, line 82 at r1 (raw file):
Previously, jarifibrahim (Ibrahim Jarif) wrote…
We could add a cancel API on stream writer to fix this in a more elegant way.
Add a Cancel API as you suggested.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim and @vvbalaji-dgraph)
|
Closing this PR since we don't need it anymore. |
ajeetdsouza
changed the title
The stream write blocks writes to badger and if we don't call
writer.flushwe will never unblock the writesThis change is
Docs Preview: