fix(ludicrous mode): Handle deletes correctly #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ludicrous mode we were trying to fetch the list of types (and their predicates) using a timestamp of 0. This would cause deletes to be ineffective and the actual data won't be deleted. This PR fixes it.
jarifibrahim
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 3, 2020
In ludicrous mode, we were trying to fetch the list of types (and their predicates) using a timestamp of 0. This would cause deletes to be ineffective and the actual data won't be deleted. This PR fixes it. Co-authored-by: Manish R Jain <manish@dgraph.io> Fixes - DGRAPH-2593 (cherry picked from commit a0cc3a5)
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 3, 2020
In ludicrous mode, we were trying to fetch the list of types (and their predicates) using a timestamp of 0. This would cause deletes to be ineffective and the actual data won't be deleted. This PR fixes it. Co-authored-by: Manish R Jain <manish@dgraph.io> Fixes - DGRAPH-2593 (cherry picked from commit a0cc3a5)
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 3, 2020
In ludicrous mode, we were trying to fetch the list of types (and their predicates) using a timestamp of 0. This would cause deletes to be ineffective and the actual data won't be deleted. This PR fixes it. Co-authored-by: Manish R Jain <manish@dgraph.io> Fixes - DGRAPH-2593 (cherry picked from commit a0cc3a5)
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 3, 2020
In ludicrous mode, we were trying to fetch the list of types (and their predicates) using a timestamp of 0. This would cause deletes to be ineffective and the actual data won't be deleted. This PR fixes it. Co-authored-by: Manish R Jain <manish@dgraph.io> Fixes - DGRAPH-2593 (cherry picked from commit a0cc3a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ludicrous mode we were trying to fetch the list of types (and their
predicates) using a timestamp of 0. This would cause deletes to be
ineffective and the actual data won't be deleted. This PR fixes it.
Fixes - DGRAPH-2593
This change is
Docs Preview: