Fix(GraphQL): Refactor Mutation Rewriter for Add and Update Mutations… #7413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#7409) * Feat(GraphQL): Refactor Mutation Rewriting for AddRewriter (#7257) * Add Existence Queries for Mutation Rewriting * Add tests * Add Error handling to getExistenceQueries * Use new code for AddRewriter * Fix Geo * Fix tests * Fix auth tests * Fix resolve tests * Fix add_mutation_test.yaml * Add bug related tests * Address more comments * Rebase * Final changes * Fix(GraphQL): Refactor Mutation Rewriting for Update Rewriter (#7383) * Fix auth tests * Refactor Update Mutation Rewriting * Fix update tests * Add comments and remove unused code * Address comments * Address more comments * Fix ACL test (cherry picked from commit d080743)
github-actions
bot
added
area/enterprise
pawanrawal
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recently, two separate PRs for add and update mutation rewriting refactor were merged to graphql_mutation_refactor branch. This cherry-pick PR is about merging all those changes to 20.11 .
Related PRs:
#7383
#7257
… (#7409)
Feat(GraphQL): Refactor Mutation Rewriting for AddRewriter (Feat(GraphQL): Refactor Mutation Rewriting for AddRewriter #7257)
Add Existence Queries for Mutation Rewriting
Add tests
Add Error handling to getExistenceQueries
Use new code for AddRewriter
Fix Geo
Fix tests
Fix auth tests
Fix resolve tests
Fix add_mutation_test.yaml
Add bug related tests
Address more comments
Rebase
Final changes
Fix(GraphQL): Refactor Mutation Rewriting for Update Rewriter (Fix(GraphQL): Refactor Mutation Rewriting for Update Rewriter #7383)
Fix auth tests
Refactor Update Mutation Rewriting
Fix update tests
Add comments and remove unused code
Address comments
Address more comments
Fix ACL test
(cherry picked from commit d080743)
This change is