Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topic(build): adding .go-version to track latest go version supported #8181

Merged
merged 2 commits into from
Sep 6, 2022
Merged

topic(build): adding .go-version to track latest go version supported #8181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1accc58
Adding .go-version to track latest go version supported
darkn3rd Aug 26, 2022
6387160
fixing the version to just 1.18 vs go1.18
skrdgraph Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .go-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
go1.18.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-goldstein there are 2 issues here:

  • test issue which you raised: this can be addressed by modifying the contents of the .go-version file from go1.18.5 -> 1.18.5 (IMO this would also make installing particular go-version more easier without having to do some regex to remove the go etc.)
  • standardize go version for builds: I think this is needed long-term to pin to a particular environment of go, this would keep the core-code / docker environments / test code etc. all tied to .go-version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly, I agree completely with the second point. 👍 Just wanted to point out the first point you mentioned.