topic(build): adding .go-version to track latest go version supported #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkn3rd
requested review from
akon-dey,
gajanan-dgraph and
skrdgraph
as code owners
skrdgraph
reviewed
Aug 29, 2022
.go-version
Outdated
| @@ -0,0 +1 @@ | |||
| go1.18.5 | |||
There was a problem hiding this comment.
@joshua-goldstein there are 2 issues here:
testissue which you raised: this can be addressed by modifying the contents of the.go-versionfile fromgo1.18.5->1.18.5(IMO this would also make installing particular go-version more easier without having to do some regex to remove thegoetc.)standardize go versionfor builds: I think this is needed long-term to pin to a particular environment ofgo, this would keep the core-code / docker environments / test code etc. all tied to.go-version.
There was a problem hiding this comment.
Yes exactly, I agree completely with the second point. 👍 Just wanted to point out the first point you mentioned.
|
@joshua-goldstein - I have made the fixes in 6387160, I think it's safe to merge. FYI @darkn3rd ... could you review? |
joshua-goldstein
approved these changes
Sep 6, 2022
dshekhar95
pushed a commit
that referenced
this pull request
Sep 12, 2022
…#8181) * Adding .go-version to track latest go version supported * fixing the version to just 1.18 vs go1.18 Co-authored-by: Sudhish <108091997+skrdgraph@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dgraph is built in different go versions that are inconsistent, such as go1.14 or go.1.16. Some versions can cause non-deterministic results when troubleshooting issues, and this could violate any compliance industry should locking down versions of libraries becomes important.
Solution
This adds versioning mechanism to lock latest go version supported by Dgraph. Scripts can be made to use this as a source of truth to explicitly set the version of go.