-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit to use badger instead of RocksDB #932
Conversation
On loading golden data, killing and restarting the server, I'm seeing this crash:
|
Change looks good. Let's keep this in a branch until we have ironed out all the issues. We'll push this out to our demo, and play etc., so it would live tested. Also, I'll try loading the entire Freebase dataset with this branch; and launch freebase.dgraph.io. That should also help test this thing. Reviewed 44 of 44 files at r1. worker/backup.go, line 258 at r1 (raw file):
why can't we just do it.Seek? Why did you create another iterator? Comments from Reviewable |
Review status: 32 of 1335 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke. worker/backup.go, line 258 at r1 (raw file): Previously, manishrjain (Manish R Jain) wrote…
We do it now, I suppose the hack was put in place because of the bug in it.Seek Comments from Reviewable |
Merged to master |
Not committing until we are more sure and do more tests. Just sending out for review first.
This change is