Theme's exampleSite directory was deleted #7
Comments
|
Hi @onedrawingperday, thanks for getting in touch and thanks for doing the hard work of maintaining this great project. Although hugo-dgraph-theme is open source it is not maintained for general purpose use - we built it for our blog and as we aren't designers I don't think it's good enough to be useful to others out-of-the-box. We welcome anyone to fork it and do whatever the current license (MIT) permits, but providing support for external builds is something I don't have resources for. I deleted the exampleSite because someone raised an issue that it was broken, and I didn't want to mislead anyone into thinking that exampleSite is maintained. We test our theme every time we update our blog and that's been good enough for now. Can you recommend a low maintenance approach to keep the theme in the gallery or could you just drop it from there? |
We can add this theme to the I will send a PR to the Hugo Themes repo. If it's accepted I will let you know. |
One of the theme authors indicated that this theme is not meant for out-of-the-box use. They asked for a low maintenance option while keeping this theme in the showcase. I offered to add the theme in the `noDemo` array of the Build Script so that it doesn't throw errors during deployment. Also see: dgraph-io/hugo-dgraph-theme#7 (comment)
|
The PR to add this theme in the |
|
Hey guys, I'm a big fan of Hugo. I'm not sure how much work is it, but @paulftw if you can fix up the issues and make it workable, I'd like the theme to be featured the same way as it was before. Thanks for letting us know, @onedrawingperday . We'll get back with some update and direction. |
|
When gohugoio/hugoThemes#576 is merged it will be possible to have your theme's demo published once again on the Hugo website. However the logo in the header will be 404 because your associate deleted the exampleSite. You really need to revert commit cb69c26 for your theme's logo to appear as it was before. Let me know once this issue is addressed so that I can remove your theme from the |
Since #547 the `contentDir` is inherited from the HugoBasicExample. This PR moves the check whether a `contentDir` exists within the `whiteList` condition, so that this check is performed only for themes whose content directories are permitted. Also this PR fixes the following theme demos that are currently not generating: - [Infinty Hugo](https://themes.gohugo.io/infinity-hugo/) ref: themefisher/infinity-hugo#2 - [D-Graph]() ref:dgraph-io/hugo-dgraph-theme#7 After this PR is merged I will send a PR to revert commit 57421eda81dbb1dada62af067 so that the D-Graph theme is removed from the `noDemo` array.
onedrawingperday
changed the title
|
Hey @onedrawingperday I've put the ExampleSite back and also tested the theme with the HugoBasicExample you've linked when opening the issue. Is this enough to fully re-enable our theme in the gallery? Please let me know what else I can do to improve presentation and make it more useful. |
|
@paulftw Thank you for issuing a fix to this issue. There is nothing more that needs to be done from your part. Once gohugoio/hugoThemes#591 is merged in the Hugo Themes repo and themes are updated the DGraph theme demo will generate on the Hugo website once again as it was except for its content that currently is inherited from the HugoBasicExample due to gohugoio/hugoThemes#547 I'm closing this issue as it is fixed. |
Hello @paulftw
I am one of the maintainers of the Hugo Themes repository.
In commit cb69c26 you deleted the exampleSite of your theme and as a result your theme demo no longer generates.
If you no longer wish to have an exampleSite then you need to test your theme with the HugoBasicExample
ref: gohugoio/hugoThemes#531
cc: @digitalcraftsman
The text was updated successfully, but these errors were encountered: