This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Closed
Merged
Closed
Closed
This was referenced Feb 16, 2019
digitalcraftsman
pushed a commit
that referenced
this pull request
Feb 22, 2019
Since #547 the `contentDir` is inherited from the HugoBasicExample. This PR moves the check whether a `contentDir` exists within the `whiteList` condition, so that this check is performed only for themes whose content directories are permitted. Also this PR fixes the following theme demos that are currently not generating: - [Infinty Hugo](https://themes.gohugo.io/infinity-hugo/) ref: themefisher/infinity-hugo#2 - [D-Graph]() ref:dgraph-io/hugo-dgraph-theme#7 After this PR is merged I will send a PR to revert commit 57421eda81dbb1dada62af067 so that the D-Graph theme is removed from the `noDemo` array.
This was referenced Feb 22, 2019
Closed
This was referenced Feb 24, 2019
10 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #546
This PR forces the Hugo Basic Example content directory in theme demos for the Hugo Themes showcase. We will be losing flexibility but we just cannot keep track of inappropriate content in theme demos.
For more details and examples of past issues see the above linked issue.
EDIT
The Netlify deploy preview succeeded.
I am asking for reviews from @digitalcraftsman @bep