Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more structured access to metrics. #59

Closed
tcolgate opened this issue Sep 24, 2019 · 2 comments
Closed

more structured access to metrics. #59

tcolgate opened this issue Sep 24, 2019 · 2 comments
Assignees
Labels
kind/enhancement Something could be better.
Milestone

Comments

@tcolgate
Copy link

Metrics returns a private type that doesn't show it's methods in the GoDoc. Ideally I'd like to be able to expose the metrics to a prometheus collector. It looks like I could possibly parse some string formatted output, but, ideally, I'd be able to get a current set of structuted mwtrics from the call.

@karlmcguire karlmcguire self-assigned this Sep 24, 2019
@karlmcguire karlmcguire added the kind/enhancement Something could be better. label Sep 24, 2019
@karlmcguire
Copy link
Contributor

Yea, I see no reason why we can't expose all of it publicly.

@tcolgate
Copy link
Author

The metrics structure is pretty clear that it doesn't want anyone looking at it :) How about having the Metrics() call return a different type with a snapshot of the internal numbers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Something could be better.
Development

No branches or pull requests

2 participants