export Metrics in a cleaner struct

[karlmcguire]

#59

---

This change is 

[tcolgate]

This looks good.

[manishrjain]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim, @karlmcguire, and @manishrjain)

---

cache.go, line 294 at r1 (raw file):

// Metrics returns statistics about cache performance.
func (c *Cache) Metrics() *metrics {

There should be a way to only retrieve a specific metric instead of all the metrics every time.

[tcolgate]

There should be a way to only retrieve a specific metric instead of all the metrics every time.

From my PoV, and I suspect a lot of users of this, I'll be sticking a prom collector on the front of this and exposing all the metrics on every scrape. That seems like it would be the more common use case.

[karlmcguire]

There should be a way to only retrieve a specific metric instead of all the metrics every time.

I agree, and we can do that internally. But for the exported function, a "snapshot" with all the struct fields seems good enough.

[karlmcguire]

Reviewed 5 of 6 files at r2.
Dismissed @manishrjain from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim)

---

cache.go, line 294 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

There should be a way to only retrieve a specific metric instead of all the metrics every time.

Done.