Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support msync for windows #283

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

chux0519
Copy link

@chux0519 chux0519 commented Sep 7, 2021

Hi, I encountered a windows power loss caused problem while using badger, and see that msync on windows is not supported.

I add the implementation and test it in a windows10 VM, it just works.

see: https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-flushviewoffile


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2021

CLA assistant check
All committers have signed the CLA.

@maddie
Copy link
Contributor

maddie commented Sep 28, 2021

@chux0519 Would you please sign the CLA to let this PR go forward? Thanks!

@chux0519
Copy link
Author

chux0519 commented Sep 28, 2021

I’ve checked this already,and I’m pretty sure the email is correct,should I recommit and push again

Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR. 🎉

@NamanJain8
Copy link
Contributor

NamanJain8 commented Sep 28, 2021

@chux0519 Can you try re-signing the CLA, please? Maybe from the PC this time.

@chux0519
Copy link
Author

@chux0519 Can you try re-signing the CLA, please? Maybe from the PC this time.

image
same, the CLA seem's doesn't know me
Should I change the user.name of git to chux0519 (currently is Yongsheng Xu) as showen in the picture and recommit again?

image

@NamanJain8
Copy link
Contributor

NamanJain8 commented Sep 28, 2021

Yeah true, you have made a commit as Yongsheng Xu. That's why the CLA is complaining. I think if you remove that commit and push the changes using key-based (and not username password) access to Github, it would accept it.

@chux0519
Copy link
Author

chux0519 commented Sep 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants