Joshua/fix .go version #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrdgraph
reviewed
Aug 18, 2022
| @@ -1 +1 @@ | |||
| go1.17.11 | |||
| 1.17.11 | |||
There was a problem hiding this comment.
nice catch @joshua-goldstein ... now the tests are running (and progressing further than before)
joshua-goldstein
force-pushed
the
joshua/fix-.go-version
branch
from
c31e454
to
3c20a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test.sh has a variable GOVERSION that checks if there is a file .go-version and sets GOVERSION to the value specified in the file. This is then used as a tag for the appropriate Docker image of Go. The previous value was go1.17.11 which is not a valid tag in the Go Docker hub (it should omit the prefix go). This was causing the test to fail.