Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench hit ratio updates #35

Merged
merged 23 commits into from Aug 14, 2019
Merged

bench hit ratio updates #35

merged 23 commits into from Aug 14, 2019

Conversation

karlmcguire
Copy link
Contributor

@karlmcguire karlmcguire commented Aug 14, 2019

  • ARC and LIRS trace file parsing
  • cache configs matching @dgryski's cachetest, hit ratios matching as well
  • move hit ratio tests to single thread/goroutine
  • decoupled Policy stats collection from ristretto package (fixing bench fails to build #34)
  • improved Clairvoyant/Optimal Policy because we're running massive ARC traces and it needs to be fast (it should be O(n lg n))
  • documentation of sim package, a start to comprehensive documentation

This change is Reviewable

bench/cache.go Outdated Show resolved Hide resolved
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Remember to add a README about how to use these benchmarks.

Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karlmcguire)

Copy link
Contributor Author

@karlmcguire karlmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 14 files reviewed, 1 unresolved discussion (waiting on @golangcibot and @manishrjain)


bench/cache.go, line 49 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…

S1019: should use make(map[string]uint64) instead (from gosimple)

Done.

Copy link
Contributor Author

@karlmcguire karlmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @golangcibot from a discussion.
Reviewable status: 10 of 14 files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link
Contributor Author

@karlmcguire karlmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 13 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karlmcguire karlmcguire merged commit e2ae6f5 into master Aug 14, 2019
@karlmcguire karlmcguire deleted the karl/sim branch August 14, 2019 22:01
@karlmcguire karlmcguire mentioned this pull request Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants