Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchronous Set/Del calls #62

Merged
merged 1 commit into from
Sep 25, 2019
Merged

synchronous Set/Del calls #62

merged 1 commit into from
Sep 25, 2019

Conversation

karlmcguire
Copy link
Contributor

@karlmcguire karlmcguire commented Sep 24, 2019 •
edited by manishrjain
Loading

Manish and I determined that this was the simplest solution to this issue (#52).

This change is Reviewable

manishrjain
manishrjain approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim)

@martinmr martinmr merged commit 884587d into master Sep 25, 2019
@martinmr martinmr deleted the karl/race branch September 25, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlmcguire @manishrjain @martinmr