Skip to content

Commit

Permalink
apacheGH-37463: [R] CRAN incoming checks fail due to test run length (a…
Browse files Browse the repository at this point in the history
…pache#37464)

### Rationale for this change

Initial CRAN checks fail as it takes too long to run

### What changes are included in this PR?

Skip tests for dplyr function bindings on CRAN

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37463

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
  • Loading branch information
thisisnic authored and dgreiss committed Feb 17, 2024
1 parent 33e72d0 commit 2b69fb2
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-conditional.R
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ library(dplyr, warn.conflicts = FALSE)
suppressPackageStartupMessages(library(bit64))

skip_if_not_available("acero")
# Skip these tests on CRAN due to build times > 10 mins
skip_on_cran()

tbl <- example_data
tbl$verses <- verses[[1]]
Expand Down
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-datetime.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ library(lubridate, warn.conflicts = FALSE)
library(dplyr, warn.conflicts = FALSE)

skip_if_not_available("acero")
# Skip these tests on CRAN due to build times > 10 mins
skip_on_cran()

# base::strptime() defaults to local timezone
# but arrow's strptime defaults to UTC.
Expand Down
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-math.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
library(dplyr, warn.conflicts = FALSE)

skip_if_not_available("acero")
# Skip these tests on CRAN due to build times > 10 mins
skip_on_cran()

test_that("abs()", {
df <- tibble(x = c(-127, -10, -1, -0, 0, 1, 10, 127, NA))
Expand Down
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-string.R
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

skip_if_not_available("utf8proc")
skip_if_not_available("acero")
# Skip these tests on CRAN due to build times > 10 mins
skip_on_cran()

library(dplyr, warn.conflicts = FALSE)
library(lubridate)
Expand Down
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-type.R
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ suppressPackageStartupMessages(library(bit64))
suppressPackageStartupMessages(library(lubridate))

skip_if_not_available("acero")
# Skip these tests on CRAN due to build times > 10 mins
skip_on_cran()

tbl <- example_data

Expand Down
3 changes: 3 additions & 0 deletions r/tests/testthat/test-dplyr-funcs.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
# specific language governing permissions and limitations
# under the License.

# Skip these tests on CRAN due to build times > 10 mins
skip_on_cran()

test_that("register_binding()/unregister_binding() works", {
fake_registry <- new.env(parent = emptyenv())
fun1 <- function() NULL
Expand Down

0 comments on commit 2b69fb2

Please sign in to comment.