Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37463: [R] CRAN incoming checks fail due to test run length #37464

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Aug 30, 2023

Rationale for this change

Initial CRAN checks fail as it takes too long to run

What changes are included in this PR?

Skip tests for dplyr function bindings on CRAN

Are these changes tested?

No

Are there any user-facing changes?

No

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My back-of-the-napkin math from trying a few things (notably: system.time(devtools::test(filter = "^dplyr-funcs-")) and system.time(devtools::test())) suggests that this should reduce the time required to run the tests by 25%; however, this only equates to about 15 seconds of savings for me.

I think the majority of the check time is the build, though (not the tests)...will we ever be in a place where that happens reliably in less than 10 minutes?

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 30, 2023
@thisisnic
Copy link
Member Author

My back-of-the-napkin math from trying a few things (notably: system.time(devtools::test(filter = "^dplyr-funcs-")) and system.time(devtools::test())) suggests that this should reduce the time required to run the tests by 25%; however, this only equates to about 15 seconds of savings for me.

I think the majority of the check time is the build, though (not the tests)...will we ever be in a place where that happens reliably in less than 10 minutes?

We haven't had this issue before, and we have it now, so it feels like it's a recent increase in build time. Hopefully the 15 seconds will be enough for this release. What else should we be considering to speed up the build time?

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I think CRAN/future readers of our test suite would benefit from a comment above these particular skip_on_cran() bits explaining why we don't test this functionality on CRAN.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Aug 30, 2023
@assignUser
Copy link
Member

...will we ever be in a place where that happens reliably in less than 10 minutes?

If we build against system arrow yes ^^

@thisisnic thisisnic merged commit c6e2180 into apache:main Aug 31, 2023
10 of 11 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Aug 31, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c6e2180.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…pache#37464)

### Rationale for this change

Initial CRAN checks fail as it takes too long to run

### What changes are included in this PR?

Skip tests for dplyr function bindings on CRAN

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37463

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…pache#37464)

### Rationale for this change

Initial CRAN checks fail as it takes too long to run

### What changes are included in this PR?

Skip tests for dplyr function bindings on CRAN

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37463

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] CRAN incoming checks fail due to test run length
3 participants